Allow entire story to be restarted

I've created a branch for this issue with some the basics implemented:
https://github.com/bbarke/jbehave-core
https://github.com/bbarke/jbehave-core/commit/c6c7020f04ee247619d530e76f742c9e9d229aae

How it works is similar to the RestartingScenarioFailure, just throw RestartingStoryFailure somewhere within the jbehave framework and it will restart the story

Some questions/problems I have are:
reporter.get().restartedStory(story, e); does not get reported if running in multi-threaded mode (Story runner, line 254)
Also, I am not sure how to get reporting to report if a story was restarted or not.

Please advise how I can get the reporting to work correctly

Thanks in advance!

Thanks for the contribution! I'll have a look at it soon.

As for the multi-threading reporting, it should get reported by the invokeDelayed() method in the ConcurrentReporter.

Pulled commit and added restarting.story in core examples.

Can you please add a story that can verify the multi-threading behaviour?

Did some cleanup on the StoryRunner implementation. Can you please verify it works on your side?

Please add any different behaviour to restarting.story.

Great, thank you very much!

I tried the code, and if an exception is thrown from a before/after annotated method, it does not restart the story. Exceptions that happen in that area only gets logged, and does not get saved off anywhere.

The scenario would be like this: If a story fails, call the annotated method:

  @AfterScenario(uponType = ScenarioType.NORMAL, uponOutcome = Outcome.FAILURE)
  public void afterNormalScenario(UUIDExceptionWrapper uuidWrappedFailure)

Inside of that method, would be logic to restart the story if it fails the first time. Other then that don't restart.

I'll see if I can add that logic to the restarting.story, but I may have to edit a lifecycle method somewhere to do this.

I updated the restarting.story to reflect these changes, and are in pull request https://github.com/jbehave/jbehave-core/pull/71

The above pull request doesn't work when running a story with an examples table. I'm working on resolving this

The above problems have been resolved: https://github.com/jbehave/jbehave-core/pull/71

Anything I can do to help this pull request go in? I've been using this code for about a month now on our ci-server, and has been working out great.

Hi Brett, the changes are a bit tricky to track because they're spread over multiple commits.

Could you please provide in a single commit the proposed changes since the pull of Nov 10?

Thanks

Hi Mauro,
I have squished all of the change lists together, it should be much easier to read now. Let me know if there is anything else I can do to help.

Is there anything else I can do to help get this merged? Let me know if you want me to re-work any code

Hi Brett,

apologies for the delay in pulling this request. I meant to do the corresponding changes to the 4.x branch but did not get time for it. Could you perhaps have a first stab at it? Essentially changing the PerformableTree in a similar way you've modified the StoryRunner?

Cheers

Yep I can take a stab at it.

The more I think about this, the more I'm wondering if it would be better to simply have a configuration that takes a number to define how many times to restart the story if any failure occurs. This would replace trying to keep track and see if the RestartingStoryFailure exception was thrown.