Details
Improvement
Resolved
Major
Description
Running tests with meta filtering exclude scenarios from GivenStories if they do not matches meta filters.
It forces to put in dependent stories/scenarios the same meta words as in top level scenario. That causes double executions of those scenarios - first time because they are in GivenStories and second time because they march meta filter.
Should be:
GivenStories override meta filters
Actual:
Meta filters override GivenStories.
How to reproduce:
1. Create story file with some scenario without any meta words.
2. Create another story file with some scenario. In GivenStories add dependency to story file from 1). Add some meta filter.
3. Run test with meta filtering.
Expected:
Executed scenario from story file 1 and 2
Actual:
Executed scenario from story file 2 and skipped scenario from story file 2.
In attachment I have putted example story files. Put them In jbehahve example eatsy-selenium/java-spring and run test with maven command:
mvn3 clean install -Dmeta.filter="+givenstories"
Activity
Mauro Talevi
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 3.7.6 [ 19035 ] |
Mauro Talevi
made changes -
| Fix Version/s | 3.8 [ 19104 ] | |
| Fix Version/s | 3.7.6 [ 19035 ] |
Mauro Talevi
made changes -
| Fix Version/s | 3.x [ 16979 ] | |
| Fix Version/s | 3.8 [ 19104 ] |
I've had to add a nasty hack to our testing framework in order to work around this bug. We use meta tags extensively to allow users to run individual stories and scenarios, but this breaks completely if the givenstories don't inherit those meta tags.
Stephen de Vries
added a comment - I've had to add a nasty hack to our testing framework in order to work around this bug. We use meta tags extensively to allow users to run individual stories and scenarios, but this breaks completely if the givenstories don't inherit those meta tags. Mauro Talevi
made changes -
| Fix Version/s | 3.x [ 16979 ] | |
| Fix Version/s | 3.9.1 [ 19830 ] |
The behaviour should be configurable.
Mauro Talevi
added a comment - The behaviour should be configurable. Made behaviour configurable via StoryControls:
StoryControls.doIgnoreMetaFiltersIfGivenStory(true)
Mauro Talevi
added a comment - Made behaviour configurable via StoryControls:
StoryControls.doIgnoreMetaFiltersIfGivenStory(true) Mauro Talevi
made changes -
| Resolution | Fixed [ 1 ] | |
| Assignee | Mauro Talevi [ maurotalevi ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
Mauro Talevi
made changes -
| Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
| Summary | Meta filters excludes stories listed in GivenStories | Allow meta filters to ignore stories listed in GivenStories |
This can be worked around by specifying the Main story name or story names comma separated. However for the number of stories I need to run this is not practical. As of jbehave-core 3.8 this is still broken.
Can we please get a fix?