uuidWrappedFailure is null when failure occurs

Mauro Talevi added a comment - 23/Nov/12 1:05 PM Can you share the simplest sample project with your config that reproduces the problem?

Alexander Lehmann added a comment - 23/Nov/12 7:37 PM to create a sample project, take the java-spring project from the tutorial and remove all steps except the first givenIAmOnEtsycom put just fail() in the the method. Then add the screenshot step to the spring bean xml file.

Damien LG added a comment - 24/Nov/12 11:23 AM - edited Thanks for the answer ! I just added this bean to the Spring config "etsy-steps.xml" : <bean id="screenshotOnFailureDriver" class="org.jbehave.web.selenium.WebDriverScreenshotOnFailure"> <constructor-arg ref="driverProvider"/> </bean> I have just tried with a fresh clone from git, nothing change but new bean in spring and versions in POM : <jbehave.core.version>4.0-beta-2</jbehave.core.version> <jbehave.web.version>3.5.4</jbehave.web.version> <jbehave.site.version>3.1.1</jbehave.site.version> <fluent.selenium.version>1.6.3</fluent.selenium.version> <selenium.version>2.26.0</selenium.version> I have added a screenshot in attachments.

Alexander Lehmann added a comment - 25/Nov/12 7:16 AM I have tracked this down to a null parameter in PerfomableTree that should be the uuid exception if there is a failure. The diff below are my changes, not thoroughly tested, a unit test would be good (the screenshot now works for the esty test, but there may be more failures). The strange formatting is due to tabs in the source code, I can do a more elaborate diff maybe with a unit test later today when I have set up my git repositories again properly. diff --git a/jbehave-core/src/main/java/org/jbehave/core/embedder/PerformableTree.java b/jbehave-core/src/main/java/org/jbehave/core/embedder/PerformableTree.java index dcbd812..da9fc51 100644 --- a/jbehave-core/src/main/java/org/jbehave/core/embedder/PerformableTree.java +++ b/jbehave-core/src/main/java/org/jbehave/core/embedder/PerformableTree.java @@ -848,7 +848,13 @@ public class PerformableTree { results = new ArrayList<StepResult>(); for (Step step : steps) { context.interruptIfCancelled(); - state = state.run(step, results, reporter, null ); + UUIDExceptionWrapper uuidFailure; + if (state instanceof SomethingHappened) { + uuidFailure = ((SomethingHappened)state).scenarioFailure; + } else { + uuidFailure = null ; + } + state = state.run(step, results, reporter, uuidFailure); } context.stateIs(state); List<PendingStep> pendingSteps = pendingSteps(steps); (two style questions: I think it would easier if the State interface had a method getScenarioFailure that returns null if it is not SomethingHappened, unless you prefer to keep the interface to the single method that is really implemented by both classes The if would be easier as ?: expression, unless we consider that statement undesirable state = state.run(step, results, reporter, state instanceof SomethingHappened ? ((SomethingHappened)state).scenarioFailure : null ; )

Mauro Talevi added a comment - 25/Nov/12 8:45 AM Implemented solution suggested by Alex and pushed 4.0-beta-3.

Damien LG added a comment - 26/Nov/12 1:58 AM Ok fixed in 4.0-beta-3, thanks for the help !