JBehave
  1. JBehave
  2. JBEHAVE-899

Support Needle as DI and Mocking Framework

    Details

    • Type: New Feature New Feature
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.9
    • Component/s: Core
    • Labels:
      None
    • Number of attachments :
      0

      Description

      I want to contribute a JBehave module supporting Needle as DI/Mocking framework (http://needle.spree.de/), similiar to other existing (Guice, Spring, Weld). As a result, one could use Needle inside of JBehave which would ease testing of JEE components.

      My first implementation is already committed to the fork: https://github.com/holisticon/jbehave-core
      Currently it already provides NeedleStepsFactory and I'm working on @UsingNeedle annotation right now.

        Activity

        Hide
        Simon Zambrovski added a comment -

        Holisticon AG as a company and Simon Zambrovski as a person are forgoing any IP and ownership on the code in favour of JBehave project.

        Show
        Simon Zambrovski added a comment - Holisticon AG as a company and Simon Zambrovski as a person are forgoing any IP and ownership on the code in favour of JBehave project.
        Mauro Talevi made changes -
        Field Original Value New Value
        Fix Version/s 3.9 [ 19035 ]
        Hide
        Mauro Talevi added a comment -

        I've merged the contributed module to master.

        A couple of comments:

        • Updated it to latest master examples' naming (see JBEHAVE-919)
        • Could not get the unit test class of the needle example to compile via Maven on JDK 1.7. Please have a look at and re-add it.
        • The needle stories run but there seem to be lots of pending steps. Please have a look at the steps' injection.

        Please update your clone to latest master.

        Thanks for the contribution!

        Show
        Mauro Talevi added a comment - I've merged the contributed module to master. A couple of comments: Updated it to latest master examples' naming (see JBEHAVE-919 ) Could not get the unit test class of the needle example to compile via Maven on JDK 1.7. Please have a look at and re-add it. The needle stories run but there seem to be lots of pending steps. Please have a look at the steps' injection. Please update your clone to latest master. Thanks for the contribution!
        Hide
        Simon Zambrovski added a comment -

        Had a look on it, will try to fix unit tests tomorrow (CET).

        Show
        Simon Zambrovski added a comment - Had a look on it, will try to fix unit tests tomorrow (CET).
        Hide
        Simon Zambrovski added a comment -
        Show
        Simon Zambrovski added a comment - Pull request created: https://github.com/jbehave/jbehave-core/pull/51
        Hide
        Mauro Talevi added a comment -

        Pulled commits with thanks.

        One final thing to add is some documentation. Would you please provide a final pull request with some docs enhancements. Just look in the jbehave-distribution/src/site/content for other DI frameworks, such as Spring.

        Show
        Mauro Talevi added a comment - Pulled commits with thanks. One final thing to add is some documentation. Would you please provide a final pull request with some docs enhancements. Just look in the jbehave-distribution/src/site/content for other DI frameworks, such as Spring.
        Hide
        Simon Zambrovski added a comment -

        Will do next week after returing from holidays.

        Show
        Simon Zambrovski added a comment - Will do next week after returing from holidays.
        Hide
        Simon Zambrovski added a comment -

        Just added a new pull request with new documentation and new archetype https://github.com/jbehave/jbehave-core/pull/52
        Sorry, my Git is bad again, i had to rebase the latest version, but missed to do so, so the last pull request contains the commits of previous one.

        Show
        Simon Zambrovski added a comment - Just added a new pull request with new documentation and new archetype https://github.com/jbehave/jbehave-core/pull/52 Sorry, my Git is bad again, i had to rebase the latest version, but missed to do so, so the last pull request contains the commits of previous one.
        Hide
        Mauro Talevi added a comment -

        Pulled with thanks. Will push out a new 3.9 beta soon.

        Show
        Mauro Talevi added a comment - Pulled with thanks. Will push out a new 3.9 beta soon.
        Mauro Talevi made changes -
        Issue Type Improvement [ 4 ] New Feature [ 2 ]
        Mauro Talevi made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Simon Zambrovski
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: