Details
Improvement
Resolved
Minor
Description
Although step class dependencies are not recommended, in some cases it is useful (e.g. when managing a per-scenario transactional Spring context).
Currently, the order of steps in @UsingSteps instances are hashed twice,once in AnnotationFinder and once more in InstanceStepsFactory, making the order of e.g. @BeforeScenario unreliable.
Find attached new versions of these classes, based off of 3.7.5 source, where the order is retained.
Activity
Mauro Talevi
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 3.8 [ 19104 ] |
Show
Jonas Olsson
added a comment - https://github.com/mirvnillith/jbehave-core/commit/4ee794d1317086b0a3380427cf12ff62882574fe
Jonas Olsson
added a comment - https://github.com/mirvnillith/jbehave-core/commit/4ee794d1317086b0a3380427cf12ff62882574fe Mauro Talevi
made changes -
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] |
The proposed patch did not pass other tests. Instead linked hash set and map implementations are now used to ensure order.
The ensuring_order_using_steps.story has been added to trader example.
Show
Mauro Talevi
added a comment - The proposed patch did not pass other tests. Instead linked hash set and map implementations are now used to ensure order.
The ensuring_order_using_steps.story has been added to trader example.
Mauro Talevi
added a comment - The proposed patch did not pass other tests. Instead linked hash set and map implementations are now used to ensure order.
The ensuring_order_using_steps.story has been added to trader example. Mauro Talevi
made changes -
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
Mauro Talevi
made changes -
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Could you present a usecase where this is happening? Ideally in a unit test or a scenario.
Also, could you please provide the patch in a commit in github: http://jbehave.org/reference/stable/how-to-contribute.html
Thanks