JBehave
  1. JBehave
  2. JBEHAVE-710

Pending steps methods should remove even more characters

          Details

          • Type: Bug Bug
          • Status: Resolved Resolved
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: 3.5.4
          • Fix Version/s: 3.6
          • Component/s: Core
          • Labels:
            None
          • Testcase included:
            yes
          • Patch Submitted:
            Yes
          • Number of attachments :
            0

            Description

            Following up on JBEHAVE-681, I noticed that even more characters should be removed when creating the method name (e.g. %)

            I have changed the method name filter to use isJavaIdentifierPart and added a unit test to check for all characters

              Activity

              Hide
              Permalink
              Mauro Talevi added a comment -

              Do you have a commit to pull?

              Show
              Mauro Talevi added a comment - Do you have a commit to pull?
              Hide
              Permalink
              Alexander Lehmann added a comment -

              https://github.com/alexlehm/jbehave-core/commit/69645cecfd684f772b9c2dfbb06c36228c467ba3
              this commit includes the fix for JBEHAVE-680 as well since they affect the same files, can you please mark both issues as resolved

              Show
              Alexander Lehmann added a comment - https://github.com/alexlehm/jbehave-core/commit/69645cecfd684f772b9c2dfbb06c36228c467ba3 this commit includes the fix for JBEHAVE-680 as well since they affect the same files, can you please mark both issues as resolved
              Hide
              Permalink
              Alexander Lehmann added a comment -

              sorry, had some merging trouble with the other changes, i hope this can be pulled in automatically

              Show
              Alexander Lehmann added a comment - sorry, had some merging trouble with the other changes, i hope this can be pulled in automatically
              Hide
              Permalink
              Mauro Talevi added a comment -

              Pulled commit without problems.

              Show
              Mauro Talevi added a comment - Pulled commit without problems.
              Mauro Talevi made changes -
              Field Original Value New Value
              Status Open [ 1 ] Resolved [ 5 ]
              Assignee Mauro Talevi [ maurotalevi ]
              Fix Version/s 3.6 [ 17721 ]
              Resolution Fixed [ 1 ]

                People

                • Assignee:
                  Mauro Talevi
                  Reporter:
                  Alexander Lehmann
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: