JBehave
  1. JBehave
  2. JBEHAVE-1016

Eclipse plugin parser should be consistent with Core parser with regards to comments

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: eclipse-1.0
    • Component/s: Eclipse Support
    • Labels:
      None
    • Number of attachments :
      0

      Description

      The story editor (Eclipse plugin) displays a line starting with "Unable to render embedded object: File (--" as a comment line, painting it green. It does not require a space after ") not found.--". It is the same with some other keywords in the story editor, for example I can start a line with Scenario:blabla and the story editor recognizes it as a scenario.

      But the story parser of jbehave-core requires a space after a keyword like "!--". So it does not fit toghether. The story parser of jbehave-core and the one of the Eclipse plugin should parse the story in the same way. Otherwise it is misleading what the story editor displays.

      Besides that, usually comment keywords don't include a space (XML, SQL, Javadoc etc.) So it is contra intuitive in a way. But I don't know how logical it would be to make an exception just for the comment keyword but not for "Given", "Scenario" and so on. Maybe a space should be optional for all story keywords.

        Activity

        Mauro Talevi made changes -
        Field Original Value New Value
        Component/s Eclipse Support [ 15582 ]
        Affects Version/s 4.x [ 18279 ]
        Affects Version/s 3.9.3 [ 20321 ]
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Summary Core and Eclipse plugin don't use the same story parser Allow comments to not require a space after keyword
        Mauro Talevi made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Mauro Talevi made changes -
        Component/s Core [ 11086 ]
        Component/s Eclipse Support [ 15582 ]
        Affects Version/s 3.9.3 [ 20321 ]
        Fix Version/s eclipse-1.0 [ 18652 ]
        Assignee Mauro Talevi [ maurotalevi ]
        Summary Allow comments to not require a space after keyword Eclipse plugin parser should be consistent with Core parser with regards to comments
        Hide
        Mauro Talevi added a comment -

        Eclipse parser now requires a space after !-- keyword, consistent with Core.

        Show
        Mauro Talevi added a comment - Eclipse parser now requires a space after !-- keyword, consistent with Core.
        Mauro Talevi made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]

          People

          • Assignee:
            Mauro Talevi
            Reporter:
            Otto Diesel
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: