JBehave
  1. JBehave
  2. JBEHAVE-396

Throw exception if ParameterConverters cannot convert to the desired type.

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.2
    • Fix Version/s: 3.2
    • Component/s: Core
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Currently if ParameterConverters can't convert to the desired type, it just returns the parameter as a string. This then falls over in some unrelated code later in the process when it can't call the step because of mismatching parameter types. To aid in debugging this, it should throw an Exception detailing the type that it can't convert to, so it can be caught early.

        Activity

        Hide
        Daniel Godfrey added a comment -

        I've pushed a small patch to my github fork to address this.

        Show
        Daniel Godfrey added a comment - I've pushed a small patch to my github fork to address this.
        Hide
        Mauro Talevi added a comment -

        Can you please add the url of the git commit?

        Show
        Mauro Talevi added a comment - Can you please add the url of the git commit?
        Show
        Daniel Godfrey added a comment - https://github.com/dgodfrey/jbehave-core/commit/e37d143af510ede82a87e97a8eac2bbef74cb980
        Mauro Talevi made changes -
        Field Original Value New Value
        Fix Version/s 3.2 [ 16757 ]
        Hide
        Daniel Godfrey added a comment -

        I've rearranged my fork a bit, the patch for this is now in it's own branch:
        https://github.com/dgodfrey/jbehave-core/tree/jbehave_396

        Show
        Daniel Godfrey added a comment - I've rearranged my fork a bit, the patch for this is now in it's own branch: https://github.com/dgodfrey/jbehave-core/tree/jbehave_396
        Hide
        Mauro Talevi added a comment -

        Pulled patch.

        Show
        Mauro Talevi added a comment - Pulled patch.
        Mauro Talevi made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Daniel Godfrey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: