JBehave
  1. JBehave
  2. JBEHAVE-651

ant copy-depedencies improvements

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.4
    • Fix Version/s: 3.6
    • Component/s: Core
    • Labels:
      None
    • Environment:
      any
    • Number of attachments :
      0

      Description

      I have 3 suggestions for improvements of the ant copy-dependencies process (or 2 suggestions and one question=

      • update maven-ant-tasks to the current version (2.1.3)
      • the maven-ant-tasks jar shouldn't be in lib (since it is not a dependency of jbehave) maybe if should be in a subdir ant
      • is it intentional that the binary distribution doesn't contain any binaries? It just downloads the jbehave jars along with the dependencies.

        Activity

        Hide
        Mauro Talevi added a comment -

        Please feel free to attach patch for first two points.

        Yes, it is intentional to avoid having big bloated distributions. It's very easy to download and cache dependencies.

        Show
        Mauro Talevi added a comment - Please feel free to attach patch for first two points. Yes, it is intentional to avoid having big bloated distributions. It's very easy to download and cache dependencies.
        Mauro Talevi made changes -
        Field Original Value New Value
        Summary ant copy-depedencies improvments ant copy-depedencies improvements
        Fix Version/s 3.6 [ 17721 ]
        Hide
        Alexander Lehmann added a comment - - edited

        fix for the first two items

        https://github.com/alexlehm/jbehave-core/commit/3a8aeae9806e930a29bc63943c0edea1fbac89b4

        (not sure if I have to send a pull request, I'm still somewhat of a git beginner)

        Show
        Alexander Lehmann added a comment - - edited fix for the first two items https://github.com/alexlehm/jbehave-core/commit/3a8aeae9806e930a29bc63943c0edea1fbac89b4 (not sure if I have to send a pull request, I'm still somewhat of a git beginner)
        Show
        Mauro Talevi added a comment - Pulled https://github.com/alexlehm/jbehave-core/commit/3a8aeae9806e930a29bc63943c0edea1fbac89b4
        Mauro Talevi made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Alexander Lehmann
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: