Details
Bug
Resolved
Minor
Description
The examples on the jbehave.org site consistently use "-skip" as meta filter to exclude stories marked with @skip true, which doesn't work, however "-skip true" works as expected.
Either the parsing of the filter condition is broken or the examples could be changed to use "-skip true".
Activity
The default MetaMatcher matches empty values as well. The behaviour is intended and verified by the examples.
Can you please attach a sample project reproducing your behaviour?
Mauro Talevi
added a comment - The default MetaMatcher matches empty values as well. The behaviour is intended and verified by the examples.
Can you please attach a sample project reproducing your behaviour? this is essentially a jbehave-simple maven project with the metaFilters rule added, if you run MyStories as unit test, you should see the difference.
Alexander Lehmann
added a comment - this is essentially a jbehave-simple maven project with the metaFilters rule added, if you run MyStories as unit test, you should see the difference.
Alexander Lehmann
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | jbehave-skip.zip [ 58330 ] |
I think this case is not covered by the tests, when I add
assertFilterAllowsProperty("-skip", "skip true", false);
the test fails
Alexander Lehmann
added a comment - - edited I think this case is not covered by the tests, when I add
assertFilterAllowsProperty("-skip", "skip true", false);
the test fails additional test cases
Alexander Lehmann
added a comment - additional test cases Alexander Lehmann
made changes -
| Attachment | metafilter.diff [ 58337 ] |
If you want to match meta property "@skip true" you need to have a meta-filter with a non-empty value, e.g. "-skip *"
assertFilterAllowsProperty("-skip *", "skip true", false);
On the other hand, "@skip" is matched by "-skip", i.e. with an empty value:
assertFilterAllowsProperty("-skip", "skip", false);
Make sense?
Mauro Talevi
added a comment - If you want to match meta property "@skip true" you need to have a meta-filter with a non-empty value, e.g. "-skip *"
assertFilterAllowsProperty("-skip *", "skip true", false);
On the other hand, "@skip" is matched by "-skip", i.e. with an empty value:
assertFilterAllowsProperty("-skip", "skip", false);
Make sense? yes, that seems sensible. I guess what confused me in the beginning is that the reference pages use "@skip true" (or false) in the story examples but in the meta filters only "-skip" is used (e.g. in the maven example) which doesn't work together.
Alexander Lehmann
added a comment - yes, that seems sensible. I guess what confused me in the beginning is that the reference pages use "@skip true" (or false) in the story examples but in the meta filters only "-skip" is used (e.g. in the maven example) which doesn't work together.
Fair point, I've updated the meta-info page to use @skip without any value.
Mauro Talevi
added a comment - Fair point, I've updated the meta-info page to use @skip without any value. Mauro Talevi
made changes -
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Assignee | Mauro Talevi [ maurotalevi ] | |
| Resolution | Not A Bug [ 6 ] |
Mauro Talevi
made changes -
| Fix Version/s | 3.6 [ 17721 ] |
Actually the examples in jbehave-core/examples use "-skip" as well, so I think this is the expected behavior.