Details
Bug
Resolved
Minor
Description
I have tried to build a complete jbehave test into a jar file by maven assembly and then to run the test on another machine that doesn't have the dev system installed.
e.g. java -cp "lib*" org.junit.runner.JUnitCore de.vodafone.jbehave.rrd.runner.Runner
the reporter tries to create the files in a path that contains $PWD/file:/$PWD/lib/jbehave/view, so I assume the path is converted from the jar location to an url which then is used as a regular path, this doesn't work on Windows or creates a directory file: in linux.
(In Linux it is possible to work around this by creating a symlink from / to file:)
I'll try to attach an example project if I can narrow this down
Activity
I have found the cause of the problem already, I just didn't get around to writing a test and fix yet.
Essentially CodeLocations.codeLocationFromClass doesn't work correctly if the class is stored inside a jar
(I'll write a more elaborate explanation tonight hopefully including a fix)
Alexander Lehmann
added a comment - - edited I have found the cause of the problem already, I just didn't get around to writing a test and fix yet.
Essentially CodeLocations.codeLocationFromClass doesn't work correctly if the class is stored inside a jar
(I'll write a more elaborate explanation tonight hopefully including a fix) example project to display the behaviour
Alexander Lehmann
added a comment - example project to display the behaviour Alexander Lehmann
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | jbehave-file-bug.zip [ 59055 ] |
to reproduce the problem, run the project with mvn install package,
the resulting file jbehave_file_bug-0.0.1-SNAPSHOT-bin.zip is a stand-alone java application that can run without any development environment installed (no maven or javac)
when unpacking the zip to a new directory and running it as junit test, the wrong pathname shows up
java -cp "lib/*" org.junit.runner.JUnitCore cx.lehmann.jbehave.file_bug.Runner
Alexander Lehmann
added a comment - - edited to reproduce the problem, run the project with mvn install package,
the resulting file jbehave_file_bug-0.0.1-SNAPSHOT-bin.zip is a stand-alone java application that can run without any development environment installed (no maven or javac)
when unpacking the zip to a new directory and running it as junit test, the wrong pathname shows up
java -cp "lib/*" org.junit.runner.JUnitCore cx.lehmann.jbehave.file_bug.Runner
https://github.com/alexlehm/jbehave-core/commit/31ef505512d17f54f9ae5d47a14c722ddd166992
handle jar paths correctly
Alexander Lehmann
added a comment - https://github.com/alexlehm/jbehave-core/commit/31ef505512d17f54f9ae5d47a14c722ddd166992
handle jar paths correctly Mauro Talevi
made changes -
| Affects Version/s | 3.6 [ 17721 ] | |
| Fix Version/s | 3.6 [ 17721 ] | |
| Affects Version/s | 3.5.4 [ 18081 ] |
Pulled and applied patch with thanks!
Mauro Talevi
added a comment - Pulled and applied patch with thanks! Mauro Talevi
made changes -
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Actually, the title could be changed to "When running codeLocationFromClass inside a jar, the current path is converted to file:/home/.../file:/home/..."
Alexander Lehmann
added a comment - Actually, the title could be changed to "When running codeLocationFromClass inside a jar, the current path is converted to file:/home/.../file:/home/ ..." Mauro Talevi
made changes -
| Summary | When running jbehave unit tests from inside a jar, the current path is converted to file:/home/.../ | When acccessing codeLocationFromClass from inside a jar, the current path is converted to file:/home/.../ |
Mauro Talevi
made changes -
| Summary | When acccessing codeLocationFromClass from inside a jar, the current path is converted to file:/home/.../ | When acccessing codeLocationFromClass from inside a jar, the current path is converted to file:/home/.../ |
Mauro Talevi
made changes -
| Summary | When acccessing codeLocationFromClass from inside a jar, the current path is converted to file:/home/.../ | Current path is converted to file:/home/.../ when accessing codeLocationFromClass from inside a jar |
Hi Alex, not at all clear what you mean by "running unit tests from inside a jar" nor what you're trying to do.
Best to discuss on the user list.