Details
-
Type: Bug
-
Status: Open
-
Priority: Major
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Environment:windows XP, jdk1.6, maven2.2.1, jbehave 3.5.4 and 3.6.7
-
Testcase included:yes
-
Patch Submitted:Yes
-
Number of attachments :1
Description
How to reproduce.
1.Please open below maven project
2.Run clean install --> everything passes
3.Change jbehave spring version to 3.5.4
5.Run clean install --> test fails
In point 2, new version of jbehave is showing that failing test is passing. Even when there is explicit fail:
Then c D and <D> (FAILED)
(java.lang.AssertionError:
Expected: is "C"
got: "D"
)
Another thing is issue with whitespaces. When you remove MyStepMatcherThatIgnoresWhitespaces from configuration then story will fail as well.
First issue is critical for us if we want to be up to date with jbehave. Second is also important to remove amount of our code.
Thx
-
Hide
- jbehave_bug.zip
- 44 kB
- Maciej Madej
-
- jbehave_bug/.idea/.name 0.0 kB
- jbehave_bug/.idea/ant.xml 0.2 kB
- jbehave_bug/.idea/compiler.xml 0.7 kB
- jbehave_bug/.idea/.../profiles_settings.xml 0.1 kB
- jbehave_bug/.idea/encodings.xml 0.2 kB
- jbehave_bug/.../Maven__aopalliance_aopalliance_1_0.xml 0.5 kB
- jbehave_bug/.../Maven__commons_collections_commons_collections_3_2_1.xml 0.6 kB
- jbehave_bug/.../Maven__commons_io_commons_io_1_4.xml 0.5 kB
- jbehave_bug/.../Maven__commons_lang_commons_lang_2_5.xml 0.5 kB
- jbehave_bug/.../Maven__commons_logging_commons_logging_1_1_1.xml 0.6 kB
- jbehave_bug/.../Maven__com_thoughtworks_paranamer_paranamer_2_4.xml 0.5 kB
- jbehave_bug/.../Maven__com_thoughtworks_xstream_xstream_1_3_1.xml 0.5 kB
- jbehave_bug/.../Maven__junit_junit_4_10.xml 0.4 kB
- jbehave_bug/.../Maven__junit_junit_dep_4_8_2.xml 0.5 kB
- jbehave_bug/.../Maven__org_codehaus_plexus_plexus_utils_2_0_5.xml 0.6 kB
- jbehave_bug/.../Maven__org_freemarker_freemarker_2_3_16.xml 0.5 kB
- jbehave_bug/.../Maven__org_hamcrest_hamcrest_core_1_1.xml 0.5 kB
- jbehave_bug/.../Maven__org_hamcrest_hamcrest_integration_1_1.xml 0.6 kB
- jbehave_bug/.../Maven__org_hamcrest_hamcrest_library_1_1.xml 0.5 kB
- jbehave_bug/.../Maven__org_jbehave_jbehave_core_3_6_7.xml 0.5 kB
- jbehave_bug/.../Maven__org_jbehave_jbehave_spring_3_6_7.xml 0.5 kB
- jbehave_bug/.../Maven__org_mockito_mockito_all_1_9_0.xml 0.5 kB
- jbehave_bug/.../Maven__org_springframework_spring_aop_3_1_1_RELEASE.xml 0.6 kB
- jbehave_bug/.../Maven__org_springframework_spring_asm_3_1_1_RELEASE.xml 0.6 kB
- jbehave_bug/.../Maven__org_springframework_spring_beans_3_1_1_RELEASE.xml 0.6 kB
- jbehave_bug/.../Maven__org_springframework_spring_context_3_1_1_RELEASE.xml 0.6 kB
- jbehave_bug/.../Maven__org_springframework_spring_core_3_1_1_RELEASE.xml 0.6 kB
- jbehave_bug/.../Maven__org_springframework_spring_expression_3_1_1_RELEASE.xml 0.6 kB
- jbehave_bug/.../Maven__org_springframework_spring_test_3_1_1_RELEASE.xml 0.6 kB
- jbehave_bug/.../Maven__org_xmlmatchers_xml_matchers_0_10.xml 0.5 kB
Activity
Let me rephrase:
on jbehave 3.5.4 test failes --> correct behaviour
on jbehave 3.6.7 test passess --> BUG
Test is written in a way that it should fail.
I've had a look at the attached project but I struggle to understand what the problem is. The story is not self-explanatory.
I also don't really understand the role of the extra annotations you've introduced.
Would you be able to express your use case with a failing self-explanatory scenario using the latest release? Please don't add any extensions to the existing components, unless strictly necessary.
Ok, I'll try
But I'm little bit suprised, project is quite small and is working quite with jbehave 3.5.4. When upgrading to 3.6.7 test is not failing.
Annotations are introduced to pick only specific scenario from given story file, so that class can execute multi scenarios.
Story is simplest I could come up with. I also do not understand why I cannot add extensions if API allows me?
But never mind, I'll try to prepare more biginers example...
Thx
Apart from the use of extra annotations, which I can understand the scope, it's the story that really does not tell me what you're trying to verify.
The following scenario is not what I call self-explanatory
Scenario: abc1
Meta:
@def
Given a
When b
Then c <C> and <D>Examples:
C D C D C D C D C D C D C D C D
Please take a look at implementation, there is simple assert there, I still do not understand what is complicated here. I can write more meaningful story with real-world example but that's not the case. The case here is fact that new jbehave is "swallowing" AsserionError and showing that test has passed.
Something must have changed between 3.5.4 and 3.6.7 to introduce this behaviour. my extensions are very simple to grasp and understand
I'm sorry but your scenarios are far from straightforward to understand. I'm willing to help, but a more collaborative attitude would be most useful as well.
In particular:
- why are there 3 identical scenarios?
- what's the point of having the examples tables as you've written them?
I would appreciate the simplest possible scenario that reproduces the problem, with some comment on what is expected and why.
Thanks
OK,
I'll provide better example, simpler one. I just need some time.
Will try to keep you posted.
Thx
Not sure what the problem is here. When you upgrade from 3.5.4 to 3.6.7 a bug is fixed.
Why do you say it's a critical issue for you?