Details
Improvement
Resolved
Minor
Description
I tried to improve the tests in PrintStreamOutputBehaviour similar to the changes I did in the Template output to check if xml encoding is done correctly in all cases (it does) and if the file is actually valid xml (it wasn't, not even the expected string was).
To make this work I added an xmlunit check and changed the order of the created story to match the way a real story is created, in this case the xml is valid.
This didn't require any change to actual code, only the test code was wrong, so this is a minor issue.
Activity
Mauro Talevi
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 3.6.9 [ 18650 ] |
Please pull latest with renamed class.
Mauro Talevi
added a comment - Please pull latest with renamed class. https://github.com/alexlehm/jbehave-core/commit/7b72bfaaaa33d22abf14fb4bdfced11bfade7410
JBEHAVE-804: Improved test in PrintStreamOutputBehaviour
Added a check for valid xml to the xml test method, more elaborate pending methods, changed the sequence of the test story to be more like actual stories (dry run moved below beforeStory and pending methods before afterStory).
this way the story xml is proper xml.
This doesn't change any main code, only the test was wrong.
Alexander Lehmann
added a comment - https://github.com/alexlehm/jbehave-core/commit/7b72bfaaaa33d22abf14fb4bdfced11bfade7410
JBEHAVE-804 : Improved test in PrintStreamOutputBehaviour
Added a check for valid xml to the xml test method, more elaborate pending methods, changed the sequence of the test story to be more like actual stories (dry run moved below beforeStory and pending methods before afterStory).
this way the story xml is proper xml.
This doesn't change any main code, only the test was wrong. Mauro Talevi
made changes -
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Mauro Talevi
made changes -
| Fix Version/s | 3.7 [ 18390 ] |
I'm not 100% sure how to commit this to be independent of the previous patch I submitted for the Templatable issue, I will wait until the other patch is merged.