JBehave
  1. JBehave
  2. JBEHAVE-563

Improve story running logic such that events such as timeouts can be monitored by story reporters

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6
    • Component/s: Core
    • Labels:
      None
    • Number of attachments :
      0

      Activity

      Mauro Talevi made changes -
      Field Original Value New Value
      Fix Version/s 3.6 [ 17721 ]
      Mauro Talevi made changes -
      Component/s Core [ 11086 ]
      Hide
      Paul Hammant added a comment -

      Not only do they not receive notifications of cancelled stories, but their visitation is incomplete.

      In the case of XML output, and XSLT conversion of those into JUnit formats, it is 'best practice' to delete such corrupted XML files before the XSLT processor kicks it - because it'll just stop processing if it encounters corrupt XML

      • Paul
      Show
      Paul Hammant added a comment - Not only do they not receive notifications of cancelled stories, but their visitation is incomplete. In the case of XML output, and XSLT conversion of those into JUnit formats, it is 'best practice' to delete such corrupted XML files before the XSLT processor kicks it - because it'll just stop processing if it encounters corrupt XML Paul
      Hide
      Paul Hammant added a comment -

      Jenkins builds use the XUnit counts as a way of driving red versus green for jobs per se. Thus some stories that are cancelled, when others that are not within a job, will be reported as 'passing' by Jenkins because of the absence of failing XUnit files (remember we are deleting them as they are corrupt).

      • Paul
      Show
      Paul Hammant added a comment - Jenkins builds use the XUnit counts as a way of driving red versus green for jobs per se. Thus some stories that are cancelled, when others that are not within a job, will be reported as 'passing' by Jenkins because of the absence of failing XUnit files (remember we are deleting them as they are corrupt). Paul
      Hide
      Paul Hammant added a comment -

      Patch applied from Emiliano

      Show
      Paul Hammant added a comment - Patch applied from Emiliano
      Paul Hammant made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Hide
      Mauro Talevi added a comment -

      Need unit test for solution.

      Show
      Mauro Talevi added a comment - Need unit test for solution.
      Mauro Talevi made changes -
      Resolution Fixed [ 1 ]
      Status Resolved [ 5 ] Reopened [ 4 ]
      Mauro Talevi made changes -
      Assignee Paul Hammant [ paul ] Mauro Talevi [ maurotalevi ]
      Mauro Talevi made changes -
      Summary Improve thread cancellation logic such that reporters know about such events. Improve story cancellation logic (e.g. for timeouts) such that events can be monitored by story reporters
      Priority Minor [ 4 ] Major [ 3 ]
      Mauro Talevi made changes -
      Summary Improve story cancellation logic (e.g. for timeouts) such that events can be monitored by story reporters Improve story running logic such that events such as timeouts can be monitored by story reporters
      Mauro Talevi made changes -
      Status Reopened [ 4 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]

        People

        • Assignee:
          Mauro Talevi
          Reporter:
          Paul Hammant
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: