JBehave
  1. JBehave
  2. JBEHAVE-779

Change of ExamplesTableFactory constructor in patch release

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.4, 3.6.5
    • Fix Version/s: 3.6.6, 3.7
    • Component/s: Core
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      0

      Description

      With JBEHAVE-718 the constructor

      public ExamplesTableFactory(Keywords keywords, ResourceLoader resourceLoader,
      ParameterConverters parameterConverters)

      was changed to

      public ExamplesTableFactory(Keywords keywords, ResourceLoader resourceLoader,
      ParameterConverters parameterConverters, TableTransformers tableTranformers)

      when the TableTransformers feature was introduced.

      This is a backwards incompatible change and should not have been included like that in a patch revision with only the last digit of the version number changed, as it breaks existing code (including mine ) when going up to the latest 3.6 version.

      I suggest adding back the original constructor with a sensible default behavior.

      A pull request on GitHub will be sent: https://github.com/jbehave/jbehave-core/pull/31

        Activity

        Mauro Talevi made changes -
        Field Original Value New Value
        Fix Version/s 3.6.6 [ 18480 ]
        Hide
        Mauro Talevi added a comment -

        Constructors in ExamplesTable and ExamplesTableFactory reinstated. Thanks for heads up.

        Show
        Mauro Talevi added a comment - Constructors in ExamplesTable and ExamplesTableFactory reinstated. Thanks for heads up.
        Mauro Talevi made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mauro Talevi made changes -
        Fix Version/s 3.7 [ 18390 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Daniel Schneller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: