JBehave
  1. JBehave
  2. JBEHAVE-816

refactor methods narrateAnInterestingStory into one method

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.8
    • Fix Version/s: 3.6.9, 3.7
    • Component/s: Core
    • Labels:
    • Testcase included:
      yes
    • Patch Submitted:
      Yes
    • Number of attachments :
      0

      Description

      the different methods narrateAnInterestingStory* are difficult to maintain since they are almost but not quite the same plus the line numbers for the stack traces change if the test methods are changed since the respective methods are included at the end of each class. Moving the method to another class should cause fewer line number changes later.

        Activity

        Hide
        Alexander Lehmann added a comment - - edited

        https://github.com/alexlehm/jbehave-core/commit/033acf820c7f968be176c2dc47232c52fe86d57d

        due to the commits to the master branch, this doesn't merge anymore, i will do a new commit

        Show
        Alexander Lehmann added a comment - - edited https://github.com/alexlehm/jbehave-core/commit/033acf820c7f968be176c2dc47232c52fe86d57d due to the commits to the master branch, this doesn't merge anymore, i will do a new commit
        Hide
        Alexander Lehmann added a comment -

        https://github.com/alexlehm/jbehave-core/commits/jbehave_816

        added the date format conversion to PrintStreamOutput, now the tests are locale independent again.

        the commits are based on the branch jbehave_816, I hope you can merge that directly.

        Show
        Alexander Lehmann added a comment - https://github.com/alexlehm/jbehave-core/commits/jbehave_816 added the date format conversion to PrintStreamOutput, now the tests are locale independent again. the commits are based on the branch jbehave_816, I hope you can merge that directly.
        Mauro Talevi made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.6.9 [ 18650 ]
        Resolution Fixed [ 1 ]
        Mauro Talevi made changes -
        Fix Version/s 3.7 [ 18390 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Alexander Lehmann
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: