Spaces in path breaks StoryFinder().findPaths()

seeing the same in 3.5.3

Current 3.x design converts all code locations to URLs, which don't allow spaces, automatically encoded to %20 chars. Relative paths can contain spaces but not the base code location.

For the moment, the only workaround is not use spaces in the code locations. A new design solution will need to be found for 4.x.

I have just fixed another problem with codeLocationFromClass (JBEHAVE-729), I'll take a look if the space problem can be fixed as well

https://github.com/alexlehm/jbehave-core/commit/a45988cf23b804dda32bcdaf69403da99f84d2fd

JBEHAVE-712: Spaces in path breaks StoryFinder().findPaths()

added method getPathFromURL to replace the URL.getFile() calls which do not decode encoded chars.
The same problem appears with other chars that have to be encoded e.g. [], accented chars.
One function in LoadFromRelativeFile used URLDecoder before, which is incorrect for + chars in path
(the class doesn't have a unit test, so I couldn't actually check for that problem, but its fixed
with the new call)

JBEHAVE-635 describes a similar issue that should be fixed as well.

I think there was an issue with %5b %5d "[]" as well but I cannot find it now.

added an unit test to show the issue with + chars in path (also fixed by the commit for this issue)

https://github.com/alexlehm/jbehave-core/commit/b379d215a9404bae6d515e65909c28bac85f3a51

Great, thanks Alexander. I will try to test it when will be merged into a snapshot or a beta version.

one of the unit tests for shouldHandleSpacesAndSpecialChars to work on unix
https://github.com/alexlehm/jbehave-core/commit/219810356553e0e9dd12eb45957ef85042b0faeb

Applied patches from Alex Lehmann.

This has regressed in at least v3.9.1

Can you provide an example or a unit test reproducing the problem?

I think the old unit test should check for that, I will take a look

I haven't written a failing unit test yet but I noticed if I change my code from:

URL searchDir = codeLocationFromClass(this.getClass());
List<String> paths = new StoryFinder().findPaths(searchDir.getFile(), asList(getPathFilter()), null);

to:

URL searchDir = codeLocationFromClass(this.getClass());
List<String> paths = new StoryFinder().findPaths(searchDir, asList(getPathFilter()), null);

then the issue goes away.

At first I thought the issue had regressed but now I realise a different variant of findPaths() was being called being the one that has a String as first argument.

Sorry to have bothered you all. Thanks for the mighty quick response!